-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Fix right column group header border with virtualization #15470
[DataGrid] Fix right column group header border with virtualization #15470
Conversation
Deploy preview: https://deploy-preview-15470--material-ui-x.netlify.app/ |
managed to go through the docs and tested it here: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-sxvpym?workspaceId=87160672-f1b6-4335-8c56-44f4aa2c0a2f The original problem is gone, but now there is a little shade left. I will go on discovery on that one tomorrow: |
It's the seperator in the grid group header that is hanging there. I have no clue how I can get rid of that. From theory there probably hast to be something inside https://github.com/mui/mui-x/blob/master/packages/x-data-grid/src/components/columnHeaders/GridColumnGroupHeader.tsx like
But I need a clue, how to hide that best, since
seems too dirty. @KenanYusuf Do you have a clue? Or a material ui best practise? |
Thanks for picking this up @hendrikpeilke The last column header in the column group should have a I haven't had a chance to look into it properly, but my guess would be that the value being passed to the That would be the first place to look. Will try and dig into it more tomorrow. |
…ith-virtualization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this given it fixes the original issue, and I will follow up with a fix for the problematic separator.
Thank you for your contribution 🏆
Cherry-pick PRs will be created targeting branches: v7.x |
…15470) Co-authored-by: Kenan Yusuf <[email protected]>
…ui#15470) Co-authored-by: Kenan Yusuf <[email protected]>
Fixes #15272